Merged
Conversation
Contributor
Author
|
Looks like the clang-format workflow is working ;) |
rafaelroquetto
force-pushed
the
clang-format
branch
from
8f27a00 to
10acb3a
Compare
Contributor
Author
|
@MrAlias should this be part of the changelog? |
Contributor
I don't think so. I've update with the "Skip Changelog" label. |
MrAlias
approved these changes
Aug 19, 2025
Contributor
Author
|
@MrAlias I did some research, and I think it will be difficult to ditch the explicit reference to clang-format-19, at least for now. If we want to be 100% consistent, we have to lock to a version because there were/are bugs affecting different major clang-format versions when it comes to the parsing of macros that are impossible to workaround only by manipulating the configuration file. For instance: llvm/llvm-project#100304 It looks like something that has been fixed on clang-format-20 and this is why we see different outcomes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #2288
Introduce clang-format to ensure all C code complies to the same formatting.
Namely, this PR brings:
.clang-formatconfiguration (same as OBI)Makefiletarget -clang-formatthat will format all filesmake install-hooks- once installed, it will take care of formatting any C source code according to.clang-formatbefore finalising the commitNote: I've formatted all .C files in the tree accordingly. We might want to discuss that before this PR is merged.